It's not your forks, it's your tire pressure. Anything below about 40 psi will result in cupped front tires. I run 41 front and 43 rear. It made a world of difference. I haven't had a cupped tire since.
Thanks. I did, when I first noticed the cupping, up the tire pressure for 36
to 50 and it started to take care of the cupping. I did start to look on Google and found them after I posted, for that I am sorry. After reading a lot that has been posted on them, I am not so sure they are worth the money. I think I will do what you have done and up the tire pressure to 41.
I'm hoping that is a typo. These tires are not rated at 50 psi cold tire pressure. 40 - 42 will be OK.
PS - I agree with your conclusion about the fork brace. The person that replaced the tire for you doesn't know what he's talking about. The brace would do nothing to reduce the tires' cupping. Fork braces are a hardware version of snake oil, IMO.
Also, be aware that a certain brand of tires (the one that begins with bridge and ends with stones) are notorious for cupping as they wear. It has something to do with the tread pattern. They do get a little noisy in mid-life, but the cupping doesn't really affect their performance all that much.
Other tires will also scallop or cup as they wear, depending on the tread pattern. It can be minimized by running high pressures, but not eliminated entirely. As long as the tire carcass flexes when the weight of the bike is on it (you want it to flex some) the tread blocks will wear unevenly.
YTMMV.